Muli Ben-Yehuda's journal

December 29, 2003

Filed under: Uncategorized — Muli Ben-Yehuda @ 8:50 PM

Finished the trident TODO by lunchtime today. Patch sent.

Update: whee, Linus responds! (and is 100% correct, as usual).

Filed under: Uncategorized — Muli Ben-Yehuda @ 11:27 AM

Finding a bug in your Linux driver via a paper posted on hurts my pride. Macros that return are EVIL, damnit!

edit: obviously, I’ve fixed it. I’ll send the patch to Andrew tonight after verifying that it still works.

Filed under: Uncategorized — Muli Ben-Yehuda @ 10:05 AM

Talking about signals in Linux sysprogramming class now. trident TODO for today:

– prog_dmabuf takes a rec parameter, make it an ENUM or DEFINE, write two wrappers around it for record / playback.

– SNDCTL_DSP_GETBLKSIZE should probably ‘break’ after checking both files. Verify that other OSS sound drivers behave this way.

– remove the lock_kernel() calls from trident_mmap(), trident_release(). Figure out what it (used to) protect and verify that it’s protected.

– fix the ugly mapped = … line in trident_ioctl()

– verify that the order of cleanup in trident_remove is correct and we can’t take an interrupt when we’re no longer ready to handle it

– in trident_init_module, do we need to unregister a pci driver after registration failed? current code does, verify.

Filed under: Uncategorized — Muli Ben-Yehuda @ 1:03 AM

The trident cleanup patch is up. After I got it to compile, there was a nasty buglet were I reworked the error path cleanup in trident_probe(), and ended up doing the cleanup even if the function was successful. Oops. Then, once I got that fixed, playing my test mp3, Abba’s Gimme Gimme, started stuttering. Since I couldn’t figure out why it was happening by just looking at the code, I started unrolling changes, and playing the song again after each change. I must’ve listened to it 50 times by the time I found out the culprit… Abba – it’s not just a band, it’s an occupational hazard of sound drivers developers!

Blog at