Talking about signals in Linux sysprogramming class now. trident TODO for today:
– prog_dmabuf takes a rec parameter, make it an ENUM or DEFINE, write two wrappers around it for record / playback.
– SNDCTL_DSP_GETBLKSIZE should probably ‘break’ after checking both files. Verify that other OSS sound drivers behave this way.
– remove the lock_kernel() calls from trident_mmap(), trident_release(). Figure out what it (used to) protect and verify that it’s protected.
– fix the ugly mapped = … line in trident_ioctl()
– verify that the order of cleanup in trident_remove is correct and we can’t take an interrupt when we’re no longer ready to handle it
– in trident_init_module, do we need to unregister a pci driver after registration failed? current code does, verify.
Leave a Reply