Muli Ben-Yehuda's journal

January 3, 2004

kernel patches update

Filed under: Uncategorized — Muli Ben-Yehuda @ 5:58 PM

Two patches, sent on Thursday:

– an update to the trident humongopatch, splitting it into indentation and everything else. Will probably show up in the next -mm kernel, and then in 2.6 vanilla when akpm decides to send it on.

– a patch to support chaining of skb destructors. Only one comment so far, suggesting some optimizations I can do and one trivial fix. No word from the networking guys. I’ll wait a few days and then post an updated version, CC’d to them explicitly. I want comments, damnit! even if it’s “dude, you suck”.

Now to finish the dishes, and onwards to the next entry…

5 Comments »

  1. You should link to the lkml threads 😦

    Comment by moshez — January 3, 2004 @ 8:22 AM | Reply

    • your wish is my command
      skb destructors – http://marc.theaimsgroup.com/?l=linux-kernel&m=107298433824691&w=2
      trident cleanup – http://marc.theaimsgroup.com/?l=linux-kernel&m=107272343822802&w=2 (scroll down the thread for the split-up patch).

      Comment by mulix — January 3, 2004 @ 8:31 AM | Reply

      • Re: your wish is my command
        I am reading about the skb destructors now. How in the first place did you get the idea?

        Comment by ideawerkz — January 3, 2004 @ 8:43 AM

      • Re: your wish is my command
        I was hacking on an network driver, and wanted to allocate some objects whose lifetime was the same as skb’s. I allocated them out of a slab cache when creating the skb, and wanted to return them to the slab cache when the skb was released. When debugging it, I realized that I had a huge memory leak and didn’t know where. More debugging, and I realized that the upper layers are hijacking the destructor for their purposes, ignoring whether it was set before. Therefore, skb destructor chaining…

        Comment by mulix — January 3, 2004 @ 8:47 AM

      • Re: your wish is my command
        I see.

        Comment by ideawerkz — January 3, 2004 @ 9:09 AM


RSS feed for comments on this post. TrackBack URI

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google photo

You are commenting using your Google account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s

Blog at WordPress.com.

%d bloggers like this: